Zentrack - Forum

Subject: Description field and egate email line lenth - by: mcutting

Mon, 06 Sep 2010 02:02:04 -0500

Shameless bump :)

Subject: delete_tickets - by: sim

Tue, 24 Aug 2010 03:45:53 -0500

Version 2.6.4 deleteTicket.php on line 51 was: [code]split_from_ids[/code] should be [code]split_form_ids[/code] On the same subject in templates/deleteTicketConfirmation.php on Line 71 was: [code][/code] should be: [code]

Subject: action applicable - by: sim

Thu, 12 Aug 2010 02:47:32 -0500

In function action applicable it checks if you have enough access or if there is an override for this action. The override code doesn't work because it is ORed instead of ANDed. See bold where I changed it from OR to AND } else if( $c["owner"] > 0 ) { // here we must be the owner (or there is an override) // if we aren't the owner, check for super if( $ticket["user_id"] != $user_id ) { $user = $this->get_user($user_id); $access = $this->getAccess($user_id); $bin_access = isset($access["$bin_id"])? $access["$bin_id"] : $user["access_level"]; $access_prevents = $bin_access < $this->getSetting("level_super"); if( empty($c["override"]) && $access_prevents ) { $this->addDebug('actionApplicable', "[]must be owner or meet override", 3); return false; } } }

Subject: Allowed Attachments list - by: sim

Thu, 12 Aug 2010 01:37:33 -0500

The allowed attachment list is supposed to allow all attachments for a 0 setting. The current 2.6.4 code doesn't. Here is a patch: function checkAttachmentExt($filename) { $ext = strtolower(preg_replace('@^.*[.]([a-zA-Z0-9]+)$@', '\1', $filename)); $possibles = $this->getSetting('attachment_types_allowed'); if( $possibles && $possibles!='0' ) { $vals = split(" *, *",$possibles); if( !in_array($ext, $vals) ) { return false; } else { return true; } } return true; } 1) I added &&possibles!='0' because it is a string and it will always exist. 2) I changed the default to return true instead of false because if there is no possibles or it is 0 then it should be allowed.